Skip to content

fix: stabilize operator behaviour #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Nov 7, 2024

Fixes the following issues:

  • Previously the collector failed with a conflict error, now we re-queue that reconcile attempt, I have tracked and confirmed that eventually the conflicting reconcile succeeds.
  • Added a minimal config-check, that we might get rid of later, but it's a good-enough start IMO, partially fixes: If no tenant is assigned to a controller a wrong config is generated #22
    NOTE: I will do a follow-up PR and come up with a better config-check
  • Noticed that we could panic if a Bridge had either no source or target tenant... Fixed.
  • We are logging errors on the first reconciliation #63
  • Upon introducing Bridges, we opened up the possibility to have a Tenant with either no subs or logsource-ns's, but It wasn't possible before.

Topology differences:

BEFORE
AFTER

Signed-off-by: Bence Csati <bence.csati@axoflow.com>
@csatib02 csatib02 added bug Something isn't working enhancement New feature or request labels Nov 7, 2024
@csatib02 csatib02 self-assigned this Nov 7, 2024
@csatib02 csatib02 force-pushed the feat/stabilize-operator-behaviour branch from a385762 to 5ff1b7b Compare November 7, 2024 16:55
@csatib02 csatib02 linked an issue Nov 7, 2024 that may be closed by this pull request
@csatib02 csatib02 force-pushed the feat/stabilize-operator-behaviour branch 2 times, most recently from 09f60ab to 17a4bee Compare November 8, 2024 09:00
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
@csatib02 csatib02 force-pushed the feat/stabilize-operator-behaviour branch from 17a4bee to 591a7d2 Compare November 8, 2024 09:07
@OverOrion OverOrion removed their request for review November 8, 2024 09:19
@csatib02 csatib02 merged commit 4441da9 into main Nov 11, 2024
11 checks passed
@csatib02 csatib02 deleted the feat/stabilize-operator-behaviour branch November 11, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We are logging errors on the first reconciliation If no tenant is assigned to a controller a wrong config is generated
2 participants